Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy macOS x86 artifacts to aarch during upload #8680

Merged
merged 2 commits into from Nov 9, 2021
Merged

Conversation

kdubb
Copy link
Contributor

@kdubb kdubb commented Nov 9, 2021

Hopefully fixes #7690

I have no idea how to test this but thought I'd make this PR to get things moving. From what I can see, this should produce signed aarch artifacts during the upload to a maven repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 9, 2021

CLA Signed

The committers are authorized under a signed CLA.

@kdubb kdubb changed the title Copy x86 artifacts to aarch during upload Copy macOS x86 artifacts to aarch during upload Nov 9, 2021
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this a bit locally and believe it will work.

buildscripts/kokoro/upload_artifacts.sh Outdated Show resolved Hide resolved
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 9, 2021
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 9, 2021
@ejona86 ejona86 merged commit 6518d7b into grpc:master Nov 9, 2021
@kdubb kdubb deleted the patch-1 branch November 9, 2021 18:53
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Nov 11, 2021
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Nov 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc-gen-grpc-java not available on apple m1
4 participants