Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy macOS x86 artifacts to aarch during upload (1.42.x backport) #8691

Merged
merged 1 commit into from Nov 11, 2021

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Nov 11, 2021

Backport of #8680, for the right branch this time

CC @kdubb

It isn't entirely normal for us to backport something like this since it is technically a new feature, but it would fix an issue actively being experienced by users and give the release process change some testing while it is still fresh on our mind.

@ejona86 ejona86 added the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Nov 11, 2021
@ejona86 ejona86 merged commit 96068a1 into grpc:v1.42.x Nov 11, 2021
@ejona86 ejona86 deleted the backport-patch-1-1.42 branch November 11, 2021 22:51
@ejona86 ejona86 removed the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Nov 11, 2021
@cbeams
Copy link

cbeams commented Nov 12, 2021

Glad to see this getting fixed. Is there a v1.42.x snapshot available that contains these aarch artifacts? I see a 1.5.1-SNAPSHOT at the Sonatype repo, but no snapshots for the 1.42.x line: https://oss.sonatype.org/#nexus-search;gav~io.grpc~protoc-gen-grpc-java~1.42.*~~

/cc protocolbuffers/protobuf#9203

@ejona86
Copy link
Member Author

ejona86 commented Nov 12, 2021

The snapshots repo doesn't go through the full release process, so has only ever built protoc for one platform at a time. And it doesn't use the script involved here, so it wouldn't see aarch64 for mac.

1.41.1 1.42.1 is already tagged and built. It should be released sometime today.

@cbeams
Copy link

cbeams commented Nov 12, 2021

@ejona86 wrote:

1.41.1 is already tagged and built. It should be released sometime today.

Clarification: did you mean 1.42.1 above? 1.41.1 was released on November 5th and does not contain this fix.

@ejona86
Copy link
Member Author

ejona86 commented Nov 12, 2021

Arg. Yes. Corrected.

@cbeams
Copy link

cbeams commented Nov 12, 2021

I was able to pull down 1.42.1 today, thanks.

cbeams added a commit to cbeams/bisq that referenced this pull request Nov 12, 2021
Includes upgrading protobuf and grpc-java to compatible versions
 - protocolbuffers/protobuf#9203
 - grpc/grpc-java#8691

Upgraded to javafx 17.0.1

Still requires having a local javafx (17.0.1) sdk for reasons I don't
fully understand. This is to avoid the "No toolkit found" error. Get
this SDK from https://gluonhq.com/products/javafx/#ea.o

At this point, ./gradlew :desktop:run brings up the GUI but blows up on
what appears to be this still unfixed error:

 - sshahine/JFoenix#1187
@ejona86 ejona86 restored the backport-patch-1-1.42 branch November 18, 2021 22:31
@ejona86 ejona86 deleted the backport-patch-1-1.42 branch November 18, 2021 22:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants