okhttp: Improve internals for executor handling #9073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches what we do in ManagedChannelImplBuilder and NettyChannelBuilder. It also fixes a (probably unimportant) bug where the factory returned from swapChannelCredentials() didn't have its references to the executors so could not outlive the parent factory.
Users should be able to inject all executors. The transport shouldn't be hard-coded to create the TIMER_SERVICE, especially since a scheduler is already available to the builder.
temawi
approved these changes
Apr 15, 2022
| this.scheduledExecutorService = | ||
| checkNotNull(scheduledExecutorService, "scheduledExecutorService"); | ||
| this.scheduledExecutorServicePool = | ||
| new FixedObjectPool<>(checkNotNull(scheduledExecutorService, "scheduledExecutorService")); |
There was a problem hiding this comment.
I take it that "It's an optional parameter" in the JavaDoc is referring to scheduledExecutorService. It's not optional so the JavaDoc should change?
There was a problem hiding this comment.
I think it is meaning, "you don't have to call this method on the builder."
There is oddity here. Compare how scheduledExecutorService() handles null vs transportExecutor(). But that was existing, so I didn't touch it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll leave the two commits separate when merging. Each commit has a description discussing what is going on a bit more.