Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

okhttp: Improve internals for executor handling #9073

Merged
merged 2 commits into from Apr 15, 2022
Merged

okhttp: Improve internals for executor handling #9073

merged 2 commits into from Apr 15, 2022

Commits on Apr 8, 2022

  1. okhttp: Use ObjectPool for executors internally in Builder 

    This matches what we do in ManagedChannelImplBuilder and
NettyChannelBuilder. It also fixes a (probably unimportant) bug where
the factory returned from swapChannelCredentials() didn't have its
references to the executors so could not outlive the parent factory.
    @ejona86
    ejona86 committed Apr 8, 2022
    Copy the full SHA
    17526f7 View commit details
    Browse the repository at this point in the history

  2. okhttp: Allow keepalive scheduled executor to be overridden 

    Users should be able to inject all executors. The transport shouldn't be
hard-coded to create the TIMER_SERVICE, especially since a scheduler is
already available to the builder.
    @ejona86
    ejona86 committed Apr 8, 2022
    Copy the full SHA
    1b70f03 View commit details
    Browse the repository at this point in the history