Commits on Apr 3, 2023

1. core: Fix NPE race during hedging …

   The problem was one hedge was committed before another had drained
   start(). This was not testable because HedgingRunnable checks whether
   scheduledHedgingRef is cancelled, which is racy, but there's no way to
   deterministically trigger either race.
   
   The same problem couldn't be triggered with retries because only one
   attempt will be draining at a time. Retries with cancellation also
   couldn't trigger it, for the surprising reason that the noop stream used
   in cancel() wasn't considered drained.
   
   This commit marks the noop stream as drained with cancel(), which allows
   memory to be garbage collected sooner and exposes the race for tests.
   That then showed the stream as hanging, because inFlightSubStreams
   wasn't being decremented.
   
   Fixes grpc#9185

   

   ejona86 committed Apr 3, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 9c5307e
   • Browse repository at this point

   Copy the full SHA

   9c5307e View commit details

   Browse the repository at this point in the history