examples: Reduce boilerplate and sort scripts #10062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The point of the sorting is to reduce the chances of merge conflicts. I greatly prefer verboseness over cleverness in examples, but the tasks can only be sorted manually and there's so many of them. It is counter-productive to do this for the examples that have their own project folder, as there's so few tasks in that case that they don't need to be ordered.
temawi
approved these changes
Apr 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of the sorting is to reduce the chances of merge conflicts. I greatly prefer verboseness over cleverness in examples, but the tasks can only be sorted manually and there's so many of them.
It is counter-productive to do this for the examples that have their own project folder, as there's so few tasks in that case that they don't need to be ordered.
I don't mind if you don't like this approach. In #10059 I realized this still needed some love. Sorting the existing
applicationDistributionwas easy, but the tasks would have been a PITA.