removed strict dns check for unknown keys #10285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YifeiZhuang
reviewed
Jun 17, 2023
| DnsNameResolver.maybeChooseServiceConfig(bad, new Random(), "host"); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
please add test cases about bad key behaviour if not already exist.
YifeiZhuang
reviewed
Jun 21, 2023
| @@ -888,14 +888,13 @@ public HttpConnectProxiedSocketAddress proxyFor(SocketAddress targetAddress) { | |||
| } | |||
|
|
|||
| @Test | |||
| public void maybeChooseServiceConfig_failsOnMisspelling() { | |||
| public void maybeChooseServiceConfig_nullOnMispelling() { | |||
There was a problem hiding this comment.
I think you should verify these all:
- A
choicewith a bad key + a valid key, the choice is chosen(non-null). - A
choicewith only bad key, the choice is chosen. - A
choicemissing service config + bad key, throw. (this test case) - A
choicemissing service config + valid key, throw.
Also the test case name is not accurate.
|
The fix seems right to me but the test is incomplete. |
|
This is put on hold until a cross language decision is made on #6579 (in about two weeks). |
tonyjongyoonan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6579 describes a service config validation issue.
Specifically, the service config error handling proposal details that we should ignore unknown keys in our service config. This is consistent with the C and Go implementations.
However, a different proposal suggests that an unknown field should invalidate a service config.
This is a fix that is consistent with the former proposal (and the C and Go implementations) and ignores unknown keys in our service config.
(no consensus reached, on hold)