api, core: rename ChannelBuilders' nameResolverFactory to nameResolverFactory_deprecated as a precursor to removing the method #10460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rFactory_deprecated as a precursor to removing the method
|
I thought we discussed in today's meeting that we'd add the new deprecated-in-the-name method, and wait a release before deleting the no-deprecated-in-name method. |
Oh, sorry I probably missed that (adding a new "deprecated" method and then deleting the old method instead of renaming). Will do that |
|
Will open a new one with the right fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step in fixing #7133
The method will be eventually removed after user responses to the renaming
CC @ejona86