Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core,netty,okhttp,alts,inprocess: deprecate usePlaintext(boolean) #4117

Merged
merged 2 commits into from Feb 28, 2018
Merged

core,netty,okhttp,alts,inprocess: deprecate usePlaintext(boolean) #4117

merged 2 commits into from Feb 28, 2018

Conversation

carl-mastrangelo
Copy link
Contributor

Updates #1772

ejona86
ejona86 approved these changes Feb 23, 2018
View reviewed changes
core/src/main/java/io/grpc/ForwardingChannelBuilder.java Outdated
public T usePlaintext(boolean skipNegotiation) {
delegate().usePlaintext(skipNegotiation);
@SuppressWarnings("deprecation")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? I thought @Deprecated methods could call other @Deprecated methods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

core/src/main/java/io/grpc/ManagedChannelBuilder.java Outdated
*
* @throws UnsupportedOperationException if plaintext mode is not supported.
* @return this
* @since 1.0.0
*/
@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the ExperimentalApi annotation, so that users know it can actually be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@carl-mastrangelo carl-mastrangelo merged commit 7af2373 into grpc:master Feb 28, 2018
@carl-mastrangelo carl-mastrangelo deleted the usePlain branch February 28, 2018 16:53
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carl-mastrangelo @ejona86