core: do not fail RPCs if balancer address exists but grpclb is unavailable #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable. When service owner turns on grpclb through service config, it shouldn't break existing clients that don't have grpclb in their classpath. Resolves grpc#4602
ejona86
approved these changes
Dec 6, 2018
| String policy = entry.getKey(); | ||
| if (policy.equals(GRPCLB_POLICY)) { | ||
| throw new PolicyException( | ||
| GRPCLB_POLICY + " specified by Service Config but no balancer addresses exist"); |
There was a problem hiding this comment.
This looks like it should exist in gRPC LB instead. And it seems like something like that is already in GrpclbState.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When service owner turns on grpclb through service config, it
shouldn't break existing clients that don't have grpclb in their
classpath.
Resolves #4602