Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Migrate to new OpenCensus method & status tags #5996

Merged
merged 4 commits into from Aug 1, 2019
Merged

core: Migrate to new OpenCensus method & status tags #5996

merged 4 commits into from Aug 1, 2019

Commits on Jul 21, 2019

  1. core: Migrate to new OpenCensus method & status tags 

    Fixes grpc#5593 and supersedes grpc#5601

Now that census-instrumentation/opencensus-java#1854 has been merged & released as 0.21.0. We can start using the method & status tags.

Background:
Opencensus introduced new tags for status and method (census-instrumentation/opencensus-java#1115). The old views that used those tags were deprecated and new views were created that used the new tags. However grpc-java wasn't updated to use the new tags due to concern of breaking existing metrics. This resulted in the old views being deprecated while the new views were broken (goomics grpc#50).

census-instrumentation/opencensus-java#1854 added a compatibility layer to opencensus that would remap new tags to old tags for old views. This should unblock grpc to switching to the new tags while allowing old views to still be populated. That commit was released as part of opencensus 0.21, which grpc currently uses
    @igorbernstein2
    igorbernstein2 committed Jul 21, 2019
    Copy the full SHA
    1298210 View commit details
    Browse the repository at this point in the history

  2. style

    @igorbernstein2
    igorbernstein2 committed Jul 21, 2019
    Copy the full SHA
    1831357 View commit details
    Browse the repository at this point in the history

  3. Add a test for the opencensus view hack

    @igorbernstein2
    igorbernstein2 committed Jul 21, 2019
    Copy the full SHA
    8d0034a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. replace @SuppressWarnings("deprecation") with @deprecated

    @igorbernstein2
    igorbernstein2 committed Jul 23, 2019
    Copy the full SHA
    3142004 View commit details
    Browse the repository at this point in the history