Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: fix builder invocation for converting Google service account to Jwt access credential #6106

Merged
merged 3 commits into from Aug 30, 2019
Merged

auth: fix builder invocation for converting Google service account to Jwt access credential #6106

merged 3 commits into from Aug 30, 2019

Commits on Aug 29, 2019

  1. Fixed mistaken method invocation for privateKeyId getter/setter.

    @voidzcy
    voidzcy committed Aug 29, 2019
    Copy the full SHA
    ac81422 View commit details
    Browse the repository at this point in the history

  2. Added test coverage to verify jwt credentials are applied to request … 

    …metadata correctly.
    @voidzcy
    voidzcy committed Aug 29, 2019
    Copy the full SHA
    3873be3 View commit details
    Browse the repository at this point in the history

  3. No need to expose serviceUri method for testing.

    @voidzcy
    voidzcy committed Aug 29, 2019
    Copy the full SHA
    2e39c08 View commit details
    Browse the repository at this point in the history