auth: fix builder invocation for converting Google service account to Jwt access credential (backport 1.22.x) #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort of grpc#5901) Maven does not include transitive runtime dependencies in the compile-time classpath (testing shows Gradle 4 does; docs say Gradle 5 doesn't). So if a user references the shaded NettyServerBuilder without also depending on grpc-core directly, compilation will fail because AbstractServerImplBuilder couldn't be found. This isn't technically a problem, since we're not wanting to encourage users to reference the shaded classes directly. But some users will certainly reference the classes anyway and the error is pretty confusing while also being trivially worked around. In other words: it justs wastes people's time and benefits nobody. Fixes grpc#5881
Prior to 745aa0a, this target was visible publicly.
Http2ControlFrameLimitEncoder is from Netty. It is copied here as a temporary measure until we upgrade to the version of Netty that includes the class. See CVE-2019-9515
… Jwt access credential (grpc#6106) * Fixed mistaken method invocation for privateKeyId getter/setter. * Added test coverage to verify jwt credentials are applied to request metadata correctly. * No need to expose serviceUri method for testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6105 .
Backport of #6106.