-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor top-level build.gradle to avoid enabling unhelpful plugins #6131
Changes from all commits
45d3c06
19fbaf6
fb2301e
af77556
b1bb108
84d9109
ee79444
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,17 @@ | ||
buildscript { | ||
repositories { jcenter() } | ||
dependencies { classpath 'com.github.jengelman.gradle.plugins:shadow:2.0.4' } | ||
} | ||
plugins { | ||
id "java" | ||
id "maven-publish" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not move There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd just assume delete the maven plugin. I couldn't find anything that failed when I removed the maven plugin outright. That seemed suspicious to me, so I just left it in place for now to reduce the risk. |
||
|
||
apply plugin: 'com.github.johnrengelman.shadow' | ||
id "com.github.johnrengelman.shadow" | ||
id "com.google.protobuf" | ||
id "ru.vyarus.animalsniffer" | ||
} | ||
|
||
description = "gRPC: ALTS" | ||
|
||
sourceCompatibility = 1.7 | ||
targetCompatibility = 1.7 | ||
|
||
buildscript { | ||
repositories { | ||
maven { // The google mirror is less flaky than mavenCentral() | ||
url "https://maven-central.storage-download.googleapis.com/repos/central/data/" } | ||
} | ||
dependencies { classpath libraries.protobuf_plugin } | ||
} | ||
|
||
dependencies { | ||
compile project(':grpc-auth'), | ||
project(':grpc-core'), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
plugins { | ||
id "maven-publish" | ||
} | ||
|
||
description = 'gRPC: BOM' | ||
|
||
publishing { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the old behavior, you might add this in settings.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't using mavenCentral any more, so using the Google mirror isn't all that useful. But even more, it can't load the plugins from the google mirror, because the search will be based on the name
com.github.kt3k.coveralls
, notorg.kt3k.gradle.plugin:coveralls-gradle-plugin
. While there are ways to make that work, they require some effort and it doesn't seem all that helpful given most of the plugins are not available on the google mirror.