Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: upgrade to Mockito 2.28.2 #6355

Merged
merged 1 commit into from Oct 30, 2019
Merged

all: upgrade to Mockito 2.28.2 #6355

merged 1 commit into from Oct 30, 2019

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Oct 30, 2019 •
edited

Mockito 2.28.2 is the latest in its 2.X versions.

Grep result for mockito in build.gradle:

There's no 2.25.1 any more:

suztomo@suxtomo24:~/grpc-java$ grep -ilr 2.25.1 ./
suztomo@suxtomo24:~/grpc-java$

Last mockito version upgrade d35fbd7 modified the 6 files.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 30, 2019 •
edited

CLA Check
The committers are authorized under a signed CLA.

@suztomo suztomo mentioned this pull request Oct 30, 2019
Closed
@ran-su
Copy link
Member

ran-su commented Oct 30, 2019

It looks like this PR is missing couple places that version number also need to be upgraded. You could check previous PRs for reference.

@suztomo
Copy link
Contributor Author

suztomo commented Oct 30, 2019

Thank you for pointing that out. Let me check.

@suztomo
Copy link
Contributor Author

suztomo commented Oct 30, 2019

@ran-su Updated the change. Does it look good now?

creamsoup
creamsoup approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@creamsoup creamsoup added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 30, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 30, 2019
@ran-su ran-su merged commit 3134df1 into grpc:master Oct 30, 2019
@ran-su
Copy link
Member

ran-su commented Oct 30, 2019

@suztomo Merged. Thank you.

@suztomo
Copy link
Contributor Author

suztomo commented Oct 30, 2019

Thank you.

@suztomo suztomo deleted the mockito branch October 30, 2019 18:35
voidzcy pushed a commit to voidzcy/grpc-java that referenced this pull request Nov 3, 2019
@suztomo @voidzcy
all: upgrade to Mockito 2.28.2 (grpc#6355)
7219b21
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creamsoup creamsoup creamsoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suztomo @ran-su @creamsoup @grpc-kokoro