Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: Support maven_install #6553

Merged
merged 3 commits into from
Dec 30, 2019
Merged

bazel: Support maven_install #6553

merged 3 commits into from
Dec 30, 2019

Commits on Dec 30, 2019

  1. repositories.bzl: Remove omit* args in favor of existing_rule() check 

    Using existing_rule() is now the preferred way of avoiding re-defining
repositories. The function names were changed to match the name of the
repository they add. Normally we would inline all the functions, but that's
unnecessary churn since the repositories will mostly be replaced with
maven_install() in the future.
    @ejona86
    ejona86 committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    380989b View commit details
    Browse the repository at this point in the history

  2. examples: Suggest Bazel's http_repository instead of git_repository 

    http_repository is preferred by Bazel over git_repository.
    @ejona86
    ejona86 committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    72bbfcb View commit details
    Browse the repository at this point in the history

  3. bazel: Support maven_install 

    maven_install is strongly superior to previous forms of grabbing dependencies
from Maven as it computes the appropriate versions to use from the full
transitive dependencies of all libraries used by an application. It also has
much less boilerplate and includes dependencies with generated targets.

In the future we will drop the jvm_maven_import_external usages and require
maven_install, at which point we can swap to using the `@maven' repository and
no longer depend on compat_repositories.

Fixes grpc#5359
    @ejona86
    ejona86 committed Dec 30, 2019
    Configuration menu
    Copy the full SHA
    a7c38a2 View commit details
    Browse the repository at this point in the history