Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpclb: internal accessor for balancer address related attribute keys #6667

Merged
merged 3 commits into from Jan 31, 2020
Merged

grpclb: internal accessor for balancer address related attribute keys #6667

merged 3 commits into from Jan 31, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Jan 31, 2020

Patches #6637

@creamsoup
Copy link
Contributor

remove unused import

@voidzcy voidzcy force-pushed the bugfix/use_attributes_defined_in_grpclb_constants branch from 9c42bbc to db6f4aa Compare January 31, 2020 21:19
@voidzcy voidzcy changed the title grpclb: use ATTR_LB_ADDRS from GrpclbConstants instead of GrpcAttributes grpclb: fix usage of balancer address related attribute keys Jan 31, 2020
@voidzcy voidzcy changed the title grpclb: fix usage of balancer address related attribute keys grpclb: internal accessor for balancer address related attribute keys Jan 31, 2020
@voidzcy voidzcy merged commit 26bff62 into grpc:master Jan 31, 2020
@voidzcy voidzcy mentioned this pull request Feb 1, 2020
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creamsoup creamsoup creamsoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@voidzcy @creamsoup