Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix a bug in health check config propgation. #6804

Merged
merged 1 commit into from Mar 5, 2020
Merged

core: fix a bug in health check config propgation. #6804

merged 1 commit into from Mar 5, 2020

Commits on Mar 5, 2020

  1. core: fix a bug in health check config propgation. 

    The condition "effectiveServiceConfig != validServiceConfig" should
have been deleted in commit 2162ad0.

The condition was there before that commit because
NAME_RESOLVER_SERVICE_CONFIG was already in "attrs", thus it needed to
be re-added only if "effectiveServiceConfig" differs from the original
"validServiceConfig".

In contrast, ATTR_HEALTH_CHECKING_CONFIG is not in the original
"attrs" and always needs to be added.
    @zhangkun83
    zhangkun83 committed Mar 5, 2020
    Copy the full SHA
    863034d View commit details
    Browse the repository at this point in the history