Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-interop-testing: resolve build warnings #6870

Merged
merged 2 commits into from
Mar 28, 2020
Merged

android-interop-testing: resolve build warnings #6870

merged 2 commits into from
Mar 28, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Mar 27, 2020

Resolves #6866.

  • Suppressed protobuf-javalite's redundant cast warning by adding "-Xlint:-cast" compiler argument.
  • Suppressed errorprone UnnecessaryAnonymousClass warning for reused source code in grpc-interop-testing.
  • Suppressed "throw in finally" warning. (I am confused by the output of that method, so suppressed the warning instead of trying to rewrite the logic).

creamsoup
creamsoup approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@creamsoup creamsoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidzcy voidzcy merged commit 6c5a7df into grpc:master Mar 28, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@voidzcy @dfawley
android-interop-testing: resolve build warnings (grpc#6870)
d8f630f 
Suppressed compiler warnings caused by protobug-javalite and errorrprone warnings from grpc-interop-testing + "throw-in-finally".
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@creamsoup creamsoup creamsoup approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

android-interop-testing spews lots of warnings
3 participants
@voidzcy @creamsoup @ejona86