Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty: use netty default SO_BACKLOG #6956

Merged
merged 1 commit into from Apr 22, 2020
Merged

netty: use netty default SO_BACKLOG #6956

merged 1 commit into from Apr 22, 2020

Conversation

creamsoup
Copy link
Contributor

as @ejona86 pointed out, we don't need to set SO_BACKLOG in netty. see #6947 (comment)

@creamsoup creamsoup requested a review from ejona86 April 21, 2020 17:39
asdf2014
asdf2014 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@creamsoup creamsoup merged commit 0059c5a into grpc:master Apr 22, 2020
@creamsoup creamsoup deleted the remove_netty_so_backlog branch April 22, 2020 16:10
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@creamsoup @dfawley
netty: use netty default SO_BACKLOG (grpc#6956)
ce10c40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@asdf2014 asdf2014 asdf2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@creamsoup @ejona86 @asdf2014