Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECURITY.md: add instruction for disabling Conscrypt's default TrustManager #6962

Merged
merged 1 commit into from Apr 22, 2020
Merged

SECURITY.md: add instruction for disabling Conscrypt's default TrustManager #6962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion SECURITY.md
View file
Open in desktop
Expand Up @@ -232,9 +232,14 @@ import java.security.Security;
...

// Somewhere in main()
Security.insertProviderAt(Conscrypt.newProvider(), 1);
Security.insertProviderAt(
Conscrypt.newProviderBuilder().provideTrustManager(false).build(), 1);
```

Note: according to [Conscrypt Implementation Notes](https://github.com/google/conscrypt/blob/2.4.0/IMPLEMENTATION_NOTES.md#hostname-verification),
its default `HostnameVerifier` on OpenJDK always fails. This can be worked
around by disabling its default `TrustManager` implementation as shown above.

### TLS with Jetty ALPN

**Please do not use Jetty ALPN**
Expand Down