Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api, core, services: make ProtoReflectionService interceptor compatible #6967

Merged
merged 16 commits into from May 1, 2020
Merged

api, core, services: make ProtoReflectionService interceptor compatible #6967

merged 16 commits into from May 1, 2020

Commits on Apr 23, 2020

  1. Eliminate InternalNotifyOnServerBuilder interface.

    @voidzcy
    voidzcy committed Apr 23, 2020
    Copy the full SHA
    4f7462d View commit details
    Browse the repository at this point in the history

  2. Expose server reference on ServerCall interface.

    @voidzcy
    voidzcy committed Apr 23, 2020
    Copy the full SHA
    7d8547a View commit details
    Browse the repository at this point in the history

  3. Add getServer() API implementation to subclasses.

    @voidzcy
    voidzcy committed Apr 23, 2020
    Copy the full SHA
    1952927 View commit details
    Browse the repository at this point in the history

  4. Obtain server via a server interceptor.

    @voidzcy
    voidzcy committed Apr 23, 2020
    Copy the full SHA
    5b51f87 View commit details
    Browse the repository at this point in the history

  5. Eliminate callback for server build.

    @voidzcy
    voidzcy committed Apr 23, 2020
    Copy the full SHA
    9273cdd View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. Add default implementation for ServerCall.getServer().

    @voidzcy
    voidzcy committed Apr 29, 2020
    Copy the full SHA
    d268012 View commit details
    Browse the repository at this point in the history

  2. Add ExperimentalApi annotation.

    @voidzcy
    voidzcy committed Apr 29, 2020
    Copy the full SHA
    933d099 View commit details
    Browse the repository at this point in the history

  3. Remove comment requirement for using one reflection service instance … 

    …per server.
    @voidzcy
    voidzcy committed Apr 29, 2020
    Copy the full SHA
    130adde View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. Add a simple test case covering a single reflection service instance … 

    …can be shared for multiple servers.
    @voidzcy
    voidzcy committed Apr 30, 2020
    Copy the full SHA
    f50789b View commit details
    Browse the repository at this point in the history

  2. Use explicit lock

    @voidzcy
    voidzcy committed Apr 30, 2020
    Copy the full SHA
    acb2a44 View commit details
    Browse the repository at this point in the history

  3. Put server into Context.

    @voidzcy
    voidzcy committed Apr 30, 2020
    Copy the full SHA
    19fd730 View commit details
    Browse the repository at this point in the history

  4. Add an internal accessor for accessing the Context key.

    @voidzcy
    voidzcy committed Apr 30, 2020
    Copy the full SHA
    b0d15a6 View commit details
    Browse the repository at this point in the history

  5. Change ProtoReflectionService to obtain Server from Context.

    @voidzcy
    voidzcy committed Apr 30, 2020
    Copy the full SHA
    d3935fa View commit details
    Browse the repository at this point in the history

  6. Revert changes for exposing Server via ServerCall.

    @voidzcy
    voidzcy committed Apr 30, 2020
    Copy the full SHA
    e4a6b9b View commit details
    Browse the repository at this point in the history

  7. Move the Context key definition and accessor to io.grpc.

    @voidzcy
    voidzcy committed Apr 30, 2020
    1
    Copy the full SHA
    9a979c5 View commit details
    Browse the repository at this point in the history

  8. Makee context key package private.

    @voidzcy
    voidzcy committed Apr 30, 2020
    Copy the full SHA
    6277cac View commit details
    Browse the repository at this point in the history