Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5439: InProcessTransport optionally adds causal information to status #6968

Merged
merged 6 commits into from May 6, 2020

Commits on Apr 23, 2020

  1. Copy the full SHA
    7f6453a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2020

  1. inprocess: improve javadocs and method name for InProcessChannelBuild…

    …er.propagateCauseWithStatus
    
    Addresses comment in PR to change method name tranportIncludeStatusCause to something more descriptive: propagateCauseWithStatus. Updates javadoc to better describe what the propagateCauseWithStatus setting does - including the default behaviour of the method.
    reggiemcdonald committed Apr 26, 2020
    Copy the full SHA
    c9270e2 View commit details
    Browse the repository at this point in the history
  2. inprocess: remove unused method

    Addressing PR feedback, this commit removes the getter from InProcessTransport that is not used in the codebase.
    reggiemcdonald committed Apr 26, 2020
    Copy the full SHA
    e85eac9 View commit details
    Browse the repository at this point in the history
  3. inprocess, internal: creates single test to check for propagating cau…

    …se with status
    
    To address a PR comment, this commit makes the includeCauseWithStatus field of the InProcessTransport final, and adds a single test case to verify that the cause is propagated properly when configured. The field server of AbstractTransportTest had to be made protected so that it could be nullified in the test case for the after each hook.
    reggiemcdonald committed Apr 26, 2020
    Copy the full SHA
    2efad75 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. internal: Add back assertnull assertion for server status

    This commit addresses PR feedback by adding back a null assertion. Default behaviour for transports is to strip cause from status. So in AbstractTransportTest.clientCancel, server status should have a null cause.
    reggiemcdonald committed May 5, 2020
    Copy the full SHA
    4ac7beb View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. inprocess: rename InProccessTransport.stripCause to InProcessTranspor…

    …t.cleanStatus and update javadoc
    
    This commit addresses PR feedback by renaming InProcessTransport.stripCause to InProcessTransport.cleanStatus and updating the javadoc, to better reflect the fact that the status can now optionally include cause.
    reggiemcdonald committed May 6, 2020
    Copy the full SHA
    d27e075 View commit details
    Browse the repository at this point in the history