Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty: return status code unavailable when netty channel has unresolved InetSocketAddress #7023

Merged
merged 3 commits into from May 21, 2020
Merged

netty: return status code unavailable when netty channel has unresolved InetSocketAddress #7023

merged 3 commits into from May 21, 2020

Commits on May 8, 2020

  1. netty: add check for UnresolvedAddressException for netty channels wi… 

    …th unresolved InetSocketAddresses

This commit adds a check for UnresolvedAddressException in netty Utils. This change was made to ensure that netty channels built from an unresolved InetSocketAddress would return Status UNAVAILABLE instead of UNKNOWN.
    @reggiemcdonald
    reggiemcdonald committed May 8, 2020
    Copy the full SHA
    71f56cb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. netty: make netty transport test more lightweight 

    This commit addresses PR feedback to make NettyTransportTest.channelHasUnresolvedHost more lightweight.
    @reggiemcdonald
    reggiemcdonald committed May 10, 2020
    Copy the full SHA
    52a7b3a View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. netty: change try-catch to try-finally for better clarity 

    This commit addresses a PR comment to make the try-catch a try-finally. Swaps assertTrue to Truth.assertThat.
    @reggiemcdonald
    reggiemcdonald committed May 11, 2020
    Copy the full SHA
    02ec5f8 View commit details
    Browse the repository at this point in the history