Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NettyClientTransport: use getOrCreate() for new instances of ChannelLogger AttributeKey. #7048

Merged
merged 10 commits into from May 21, 2020

Commits on May 19, 2020

  1. NettyClientTransport: use getOrCreate for new instances of the `C…

    …hannelLogger` `AttributeKey`.
    
    `NettyClientTransport` throws an error when the class is loaded in two separate class-loaders because of some implementation detail with the underlying `AttributeKey` class. Instead of just blowing up when a new `ChannelLogger` key can't be created, this allows multiple, isolated class-loaders in the same JVM to just get the existing key.  If this causes issues, this `AttributeKey` should be updated to use a new UUID (or something) each time it is loaded.
    
    Improvement: Works with isolated class-loaders.
    Potential Drawback: Uses the same `ChannelLogger` `AttributeKey` object across multiple, isolated classloaders.
    voidzcy authored and Nexproc committed May 19, 2020
    Copy the full SHA
    7e19f81 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    3115cc7 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. fix line length for linter

    Nexproc committed May 21, 2020
    Copy the full SHA
    559dd0f View commit details
    Browse the repository at this point in the history
  2. make linter happy

    reorder `final static` -> `static final`
    Nexproc committed May 21, 2020
    Copy the full SHA
    9d61e27 View commit details
    Browse the repository at this point in the history
  3. make coverage happy too

    Shortened the null check to get around coverage being upset about 1 line. This lets me avoid making this getOrCreate function public just to test whether AttributeKey works.
    Nexproc committed May 21, 2020
    Copy the full SHA
    24b4e20 View commit details
    Browse the repository at this point in the history
  4. make the compiler happy

    Nexproc committed May 21, 2020
    Copy the full SHA
    9f31da4 View commit details
    Browse the repository at this point in the history
  5. maybe make compiler happy?

    Nexproc committed May 21, 2020
    Copy the full SHA
    b6f49d5 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    193f2b1 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    ff98c2a View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    e6da351 View commit details
    Browse the repository at this point in the history