Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: promote XdsNameResolver2 #7416

Merged
merged 1 commit into from Sep 11, 2020

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Sep 11, 2020

Tests look good.

One thing I noticed is

"Generated service config (method config):\n{0}", new Gson().toJson(rawServiceConfig));

might be too verbose, every single RPC will print out this log. We may want to delete it or lower its level. But that should be done in a separate PR. This PR only replaces XdsNameResolver with XdsNameResolver2. Diff is misleading.

@dapengzhang0
Copy link
Member

dapengzhang0 commented Sep 11, 2020

This PR only replaces XdsNameResolver with XdsNameResolver2. Diff is misleading.

Actually you can only make one-line change by modifying resources/META-INF/services/io.grpc.NameResolverProvider

@voidzcy
Copy link
Contributor Author

voidzcy commented Sep 11, 2020

Actually you can only make one-line change by modifying resources/META-INF/services/io.grpc.NameResolverProvider

That would still leave two copies of code, in which the old copy eventually needs to be deleted.

@dapengzhang0
Copy link
Member

That would still leave two copies of code, in which the old copy eventually needs to be deleted.

We leave two copies of code until the new resolver is working for at lease one release.

@dapengzhang0
Copy link
Member

Plus, one-line change is super easy to rollback, even new change is added to the resolver later.

@voidzcy
Copy link
Contributor Author

voidzcy commented Sep 11, 2020

Plus, one-line change is super easy to rollback, even new change is added to the resolver later.

We do not need to wait one release. We should delete the unused codepath as quick as possible. Otherwise, if we need to change something in the resolver, we need to change in both, just like the issue #7400 is facing.

Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voidzcy voidzcy merged commit 69e8204 into grpc:master Sep 11, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants