Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix floating-point number formatting Locale (v1.33.x backport) #7570

Merged
merged 1 commit into from Oct 29, 2020

Conversation

sergiitk
Copy link
Member

In some Locale, floating-point number like 1,234.56 is formatted as 1.234,56; and in some Locale, integers are formatted with non-ASCII decimal digits.

https://developer.android.com/reference/java/util/Locale.html#default_locale


This is a backport of #7473

Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the backport.

@sergiitk sergiitk merged commit af97bef into grpc:v1.33.x Oct 29, 2020
@sergiitk sergiitk deleted the backport-fix-locale branch October 29, 2020 17:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants