Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServerCredentials #7601

Merged
merged 4 commits into from Nov 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion alts/src/main/java/io/grpc/alts/AltsChannelCredentials.java
Expand Up @@ -52,6 +52,7 @@ public static Builder newBuilder() {
return new Builder();
}

@ExperimentalApi("https://github.com/grpc/grpc-java/issues/4151")
public static final class Builder {
private final ImmutableList.Builder<String> targetServiceAccountsBuilder =
ImmutableList.builder();
Expand Down Expand Up @@ -131,7 +132,7 @@ public int getDefaultPort() {

private static final AsciiString SCHEME = AsciiString.of("https");

private static final class FailingProtocolNegotiator implements ProtocolNegotiator {
static final class FailingProtocolNegotiator implements ProtocolNegotiator {
private final Status status;

public FailingProtocolNegotiator(Status status) {
Expand Down
61 changes: 5 additions & 56 deletions alts/src/main/java/io/grpc/alts/AltsServerBuilder.java
Expand Up @@ -17,45 +17,31 @@
package io.grpc.alts;

import io.grpc.BindableService;
import io.grpc.Channel;
import io.grpc.CompressorRegistry;
import io.grpc.DecompressorRegistry;
import io.grpc.ExperimentalApi;
import io.grpc.HandlerRegistry;
import io.grpc.Metadata;
import io.grpc.Server;
import io.grpc.ServerBuilder;
import io.grpc.ServerCall;
import io.grpc.ServerCall.Listener;
import io.grpc.ServerCallHandler;
import io.grpc.ServerInterceptor;
import io.grpc.ServerServiceDefinition;
import io.grpc.ServerStreamTracer;
import io.grpc.ServerTransportFilter;
import io.grpc.Status;
import io.grpc.alts.internal.AltsProtocolNegotiator;
import io.grpc.internal.ObjectPool;
import io.grpc.internal.SharedResourcePool;
import io.grpc.netty.NettyServerBuilder;
import java.io.File;
import java.net.InetSocketAddress;
import java.util.concurrent.Executor;
import java.util.concurrent.TimeUnit;
import java.util.logging.Level;
import java.util.logging.Logger;

/**
* gRPC secure server builder used for ALTS. This class adds on the necessary ALTS support to create
* a production server on Google Cloud Platform.
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/4151")
public final class AltsServerBuilder extends ServerBuilder<AltsServerBuilder> {

private static final Logger logger = Logger.getLogger(AltsServerBuilder.class.getName());
private final NettyServerBuilder delegate;
private ObjectPool<Channel> handshakerChannelPool =
SharedResourcePool.forResource(HandshakerServiceChannel.SHARED_HANDSHAKER_CHANNEL);
private boolean enableUntrustedAlts;
private final AltsServerCredentials.Builder credentialsBuilder =
new AltsServerCredentials.Builder();

private AltsServerBuilder(NettyServerBuilder nettyDelegate) {
this.delegate = nettyDelegate;
Expand All @@ -72,17 +58,13 @@ public static AltsServerBuilder forPort(int port) {
* is running on Google Cloud Platform.
*/
public AltsServerBuilder enableUntrustedAltsForTesting() {
enableUntrustedAlts = true;
credentialsBuilder.enableUntrustedAltsForTesting();
return this;
}

/** Sets a new handshaker service address for testing. */
public AltsServerBuilder setHandshakerAddressForTesting(String handshakerAddress) {
// Instead of using the default shared channel to the handshaker service, create a separate
// resource to the test address.
handshakerChannelPool =
SharedResourcePool.forResource(
HandshakerServiceChannel.getHandshakerChannelForTesting(handshakerAddress));
credentialsBuilder.setHandshakerAddressForTesting(handshakerAddress);
return this;
}

Expand Down Expand Up @@ -172,40 +154,7 @@ public AltsServerBuilder intercept(ServerInterceptor interceptor) {
/** {@inheritDoc} */
@Override
public Server build() {
if (!CheckGcpEnvironment.isOnGcp()) {
if (enableUntrustedAlts) {
logger.log(
Level.WARNING,
"Untrusted ALTS mode is enabled and we cannot guarantee the trustworthiness of the "
+ "ALTS handshaker service");
} else {
Status status =
Status.INTERNAL.withDescription("ALTS is only allowed to run on Google Cloud Platform");
delegate.intercept(new FailingServerInterceptor(status));
}
}

delegate.protocolNegotiator(
AltsProtocolNegotiator.serverAltsProtocolNegotiator(handshakerChannelPool));
delegate.protocolNegotiator(credentialsBuilder.buildProtocolNegotiator());
sanjaypujare marked this conversation as resolved.
Show resolved Hide resolved
return delegate.build();
}

/** An implementation of {@link ServerInterceptor} that fails each call. */
static final class FailingServerInterceptor implements ServerInterceptor {

private final Status status;

public FailingServerInterceptor(Status status) {
this.status = status;
}

@Override
public <ReqT, RespT> Listener<ReqT> interceptCall(
ServerCall<ReqT, RespT> serverCall,
Metadata metadata,
ServerCallHandler<ReqT, RespT> nextHandler) {
serverCall.close(status, new Metadata());
return new Listener<ReqT>() {};
}
}
}
95 changes: 95 additions & 0 deletions alts/src/main/java/io/grpc/alts/AltsServerCredentials.java
@@ -0,0 +1,95 @@
/*
* Copyright 2018 The gRPC Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc.alts;

import io.grpc.Channel;
import io.grpc.ExperimentalApi;
import io.grpc.ServerCredentials;
import io.grpc.Status;
import io.grpc.alts.internal.AltsProtocolNegotiator;
import io.grpc.internal.ObjectPool;
import io.grpc.internal.SharedResourcePool;
import io.grpc.netty.InternalNettyServerCredentials;
import io.grpc.netty.InternalProtocolNegotiator;
import java.util.logging.Level;
import java.util.logging.Logger;

/**
* gRPC secure server builder used for ALTS. This class adds on the necessary ALTS support to create
* a production server on Google Cloud Platform.
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/7621")
public final class AltsServerCredentials {
private static final Logger logger = Logger.getLogger(AltsServerCredentials.class.getName());

private AltsServerCredentials() {}

public static ServerCredentials create() {
return newBuilder().build();
}

public static Builder newBuilder() {
return new Builder();
}

@ExperimentalApi("https://github.com/grpc/grpc-java/issues/7621")
public static final class Builder {
private ObjectPool<Channel> handshakerChannelPool =
SharedResourcePool.forResource(HandshakerServiceChannel.SHARED_HANDSHAKER_CHANNEL);
private boolean enableUntrustedAlts;

/**
* Enables untrusted ALTS for testing. If this function is called, we will not check whether
* ALTS is running on Google Cloud Platform.
*/
public Builder enableUntrustedAltsForTesting() {
enableUntrustedAlts = true;
return this;
}

/** Sets a new handshaker service address for testing. */
public Builder setHandshakerAddressForTesting(String handshakerAddress) {
// Instead of using the default shared channel to the handshaker service, create a separate
// resource to the test address.
handshakerChannelPool =
SharedResourcePool.forResource(
HandshakerServiceChannel.getHandshakerChannelForTesting(handshakerAddress));
return this;
}

public ServerCredentials build() {
return InternalNettyServerCredentials.create(buildProtocolNegotiator());
}

InternalProtocolNegotiator.ProtocolNegotiator buildProtocolNegotiator() {
if (!CheckGcpEnvironment.isOnGcp()) {
if (enableUntrustedAlts) {
logger.log(
Level.WARNING,
"Untrusted ALTS mode is enabled and we cannot guarantee the trustworthiness of the "
+ "ALTS handshaker service");
} else {
Status status = Status.INTERNAL.withDescription(
"ALTS is only allowed to run on Google Cloud Platform");
return new AltsChannelCredentials.FailingProtocolNegotiator(status);
}
}

return AltsProtocolNegotiator.serverAltsProtocolNegotiator(handshakerChannelPool);
}
}
}
57 changes: 57 additions & 0 deletions api/src/main/java/io/grpc/ChoiceServerCredentials.java
@@ -0,0 +1,57 @@
/*
* Copyright 2020 The gRPC Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;

/**
* Provides a list of {@link ServerCredentials}, where any one may be used. The credentials are in
* preference order.
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/7621")
public final class ChoiceServerCredentials extends ServerCredentials {
/**
* Constructs with the provided {@code creds} as options, with preferred credentials first.
*
* @throws IllegalArgumentException if no creds are provided
*/
public static ServerCredentials create(ServerCredentials... creds) {
if (creds.length == 0) {
throw new IllegalArgumentException("At least one credential is required");
}
return new ChoiceServerCredentials(creds);
}

private final List<ServerCredentials> creds;

private ChoiceServerCredentials(ServerCredentials... creds) {
for (ServerCredentials cred : creds) {
if (cred == null) {
throw new NullPointerException();
}
}
this.creds = Collections.unmodifiableList(new ArrayList<>(Arrays.asList(creds)));
}

/** Non-empty list of credentials, in preference order. */
public List<ServerCredentials> getCredentialsList() {
return creds;
}
}
11 changes: 11 additions & 0 deletions api/src/main/java/io/grpc/Grpc.java
Expand Up @@ -124,4 +124,15 @@ private static String authorityFromHostAndPort(String host, int port) {
throw new IllegalArgumentException("Invalid host or port: " + host + " " + port, ex);
}
}

/**
* Static factory for creating a new ServerBuilder.
*
* @param port the port to listen on
* @param creds the server identity
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/7621")
public static ServerBuilder<?> newServerBuilderForPort(int port, ServerCredentials creds) {
sanjaypujare marked this conversation as resolved.
Show resolved Hide resolved
return ServerRegistry.getDefaultRegistry().newServerBuilderForPort(port, creds);
}
}
27 changes: 27 additions & 0 deletions api/src/main/java/io/grpc/InsecureServerCredentials.java
@@ -0,0 +1,27 @@
/*
* Copyright 2020 The gRPC Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc;

/** No server identity or encryption is to be used. */
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/7621")
public final class InsecureServerCredentials extends ServerCredentials {
public static ServerCredentials create() {
return new InsecureServerCredentials();
}

private InsecureServerCredentials() {}
}
37 changes: 37 additions & 0 deletions api/src/main/java/io/grpc/ServerCredentials.java
@@ -0,0 +1,37 @@
/*
* Copyright 2020 The gRPC Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc;

/**
* Represents a security configuration to be used for servers. There is no generic mechanism for
* processing arbitrary {@code ServerCredentials}; the consumer of the credential (the server)
* must support each implementation explicitly and separately. Consumers are not required to support
* all types or even all possible configurations for types that are partially supported, but they
* <em>must</em> at least fully support {@link ChoiceServerCredentials}.
*
* <p>A {@code ServerCredential} provides server identity. They can also influence types of
* encryption used and similar security configuration.
*
* <p>The concrete credential type should not be relevant to most users of the API and may be an
* implementation decision. Users should generally use the {@code ServerCredentials} type for
* variables instead of the concrete type. Freshly-constructed credentials should be returned as
* {@code ServerCredentials} instead of a concrete type to encourage this pattern. Concrete types
* would only be used after {@code instanceof} checks (which must consider
* {@code ChoiceServerCredentials}!).
*/
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/7621")
public abstract class ServerCredentials {}