Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Don't leak CallCredentials into OOB channels (1.34.x backport) #7717

Merged
merged 1 commit into from Dec 10, 2020
Merged

core: Don't leak CallCredentials into OOB channels (1.34.x backport) #7717

merged 1 commit into from Dec 10, 2020

Commits on Dec 10, 2020

  1. core: Don't leak CallCredentials into OOB channels 

    The addition of CompositeChannelCredentials allowed CallCredentials to
be passed to the ManagedChannel itself. But the implementation was buggy
and used the call creds for out-of-band channels as well, which is
inappropriate since they have a different authority.

This also fixes a bug where resolving OOB channels would have CallCreds
duplicated; that wasn't noticed or important because we don't use
CallCreds in OOB channels.

Fixes grpc#7643
    @ejona86
    ejona86 committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    234bb44 View commit details
    Browse the repository at this point in the history