Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: make subchannel creation timing restriction stricter #7790

Merged
merged 4 commits into from Jan 14, 2021
Merged

core: make subchannel creation timing restriction stricter #7790

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6bf9e0
Make the timing restriction of subchannel creation stricter. Throw at…
voidzcy Jan 8, 2021
0ba1444
Merge branch 'master' of github.com:grpc/grpc-java into bugfix/enforc…
voidzcy Jan 12, 2021
666aebd
Minor cleanup.
voidzcy Jan 12, 2021
b775db0
Simplify SubchannelImpl's start by removing handlings that should nev…
voidzcy Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/io/grpc/internal/ManagedChannelImpl.java
View file
Open in desktop
Expand Up @@ -1425,8 +1425,8 @@ public AbstractSubchannel createSubchannel(CreateSubchannelArgs args) {
}

private SubchannelImpl createSubchannelInternal(CreateSubchannelArgs args) {
// TODO(ejona): can we be even stricter? Like loadBalancer == null?
checkState(!terminated, "Channel is terminated");
// No new subchannel should be created after delayedTransport has been shutdown.
voidzcy marked this conversation as resolved.
Show resolved Hide resolved
checkState(!terminating, "Channel is being terminated");
return new SubchannelImpl(args, this);
}

Expand Down