core: Move negotiationLogger from channel attributes to handler #7933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Mar 2, 2021
netty/src/main/java/io/grpc/netty/GrpcHttp2ConnectionHandler.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Mar 10, 2021
ejona86
approved these changes
Mar 10, 2021
| * Returns the channel logger for the given channel context. | ||
| */ | ||
| public ChannelLogger getNegotiationLogger() { | ||
| checkState(negotiationLogger != null, "NegotiationLogger must not be null"); |
There was a problem hiding this comment.
Seems this should be moved to the constructor.
This reverts commit 3a0aba6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7062