Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds:fix cdsLoadBalancer2 childLb shutdown (1.36.x backport) #7976

Merged
merged 1 commit into from Mar 17, 2021
Merged

xds:fix cdsLoadBalancer2 childLb shutdown (1.36.x backport) #7976

merged 1 commit into from Mar 17, 2021

Conversation

YifeiZhuang
Copy link
Contributor

backporting #7971
fix #7942

@voidzcy voidzcy changed the title xds:fix cdsLoadBalancer2 childLb shutdown (#7942) xds:fix cdsLoadBalancer2 childLb shutdown (1.36.x backport) Mar 17, 2021
voidzcy
voidzcy approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion: you may want to put at least some information on PR description and make the commit message (when you squash the PR) a bit more informative. Unless is something super trivial.

@YifeiZhuang YifeiZhuang merged commit e3dd9ad into grpc:v1.36.x Mar 17, 2021
@YifeiZhuang YifeiZhuang deleted the v1.36.x branch March 17, 2021 00:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@voidzcy voidzcy voidzcy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YifeiZhuang @voidzcy