Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpclb: include fallback reason in error status of failing to fallback #8035

Merged
merged 4 commits into from Apr 8, 2021
Merged

grpclb: include fallback reason in error status of failing to fallback #8035

merged 4 commits into from Apr 8, 2021

Commits on Apr 1, 2021

  1. Enhance error information reflected by RPC status when failing to fal… 

    …lback (aka, no fallback addresses provided by resolver), by including the original cause of entering fallback. This falls into cases:

  - balancer RPC timeout (includes a timeout message)
  - balancer RPC failed before receiving any backend addresses (use the error occured in balancer RPC)
  - all balancer-provided addresses failed, while balancer RPC had failed causing fallback (use the error status for one of the balancer-provided backend)
    @voidzcy
    voidzcy committed Apr 1, 2021
    Copy the full SHA
    4558b74 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Delay setting the fallback reason until the fallback timer is actuall… 

    …y executing.
    @voidzcy
    voidzcy committed Apr 2, 2021
    Copy the full SHA
    1618401 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Short-circuit fallback timer if balancer RPC closes, to avoid fallbac… 

    …k reason being overwritten by timeout waiting for balancer.
    @voidzcy
    voidzcy committed Apr 6, 2021
    Copy the full SHA
    177236b View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Make no-fallback-address the primary UNAVAILABLE error of failing RPC… 

    …s when failing to fallback, attach the original fallback reason to it. This ensures all client RPCs fail with UNAVAILABLE status code. Errors being logged are still with its original status code.
    @voidzcy
    voidzcy committed Apr 7, 2021
    Copy the full SHA
    c9bd7e1 View commit details
    Browse the repository at this point in the history