Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename netty-shaded native resources directory to avoid collisions #8270

Merged
merged 1 commit into from Sep 2, 2021
Merged

Rename netty-shaded native resources directory to avoid collisions #8270

merged 1 commit into from Sep 2, 2021

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Jun 17, 2021

This renames the netty-shaded resource folder to avoid configuration collisions with standard netty. Followup to: #8258 (comment)

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 2, 2021
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 2, 2021
sergiitk
sergiitk approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sergiitk sergiitk merged commit ffebe23 into grpc:master Sep 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dzou @sergiitk @ejona86 @grpc-kokoro