Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: use <scheme,provider> map in nameResoverRegistry #8323

Merged
merged 5 commits into from Jul 21, 2021
Merged

api: use <scheme,provider> map in nameResoverRegistry #8323

merged 5 commits into from Jul 21, 2021

Conversation

YifeiZhuang
Copy link
Contributor

Part of #7133.
It makes scheme matching more explicit in name resolver API. It slightly changed the existing behaviour because in this PR we pick effective providers early/when refreshing.
But it should not change effectiveness of e.g. SecretGrpclbNameResolverProvider.

@YifeiZhuang YifeiZhuang requested a review from ejona86 July 13, 2021 17:28
@YifeiZhuang YifeiZhuang requested a review from ejona86 July 15, 2021 23:20
ejona86
ejona86 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've audited the internal NameResolverProviders and all have a SCHEME.equals(uri.getScheme()) check, so I don't think this will break anything internally.

@YifeiZhuang YifeiZhuang merged commit 4c1272f into grpc:master Jul 21, 2021
@YifeiZhuang YifeiZhuang deleted the zivy/resolver_factory branch July 21, 2021 17:03
This was referenced Sep 21, 2021
Merged
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanjaypujare sanjaypujare sanjaypujare left review comments

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YifeiZhuang @ejona86 @sanjaypujare