Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the ServerCallHandler API contract. #8339

Merged
merged 4 commits into from Jul 26, 2021
Merged

Clarify the ServerCallHandler API contract. #8339

merged 4 commits into from Jul 26, 2021

Commits on Jul 23, 2021

  1. Clarify the ServerCallHandler API contract. 

    - Focus the summary fragment
- Clarify that implementations don't just have access to "call" and
"headers" while running -- they in fact take ownership of these
arguments from the caller.
- Make explicit the caller's obligation to the returned Listener.
- Clarify that "{@code call} will be closed with an error" is actually
an obligation placed on the caller (who may be a user-defined
ServerInterceptor).
    @jdcormie
    jdcormie committed Jul 23, 2021
    Copy the full SHA
    df64d79 View commit details
    Browse the repository at this point in the history

  2. Discuss responsibility to close()

    @jdcormie
    jdcormie committed Jul 23, 2021
    Copy the full SHA
    970a13e View commit details
    Browse the repository at this point in the history

  3. in particular

    @jdcormie
    jdcormie committed Jul 23, 2021
    Copy the full SHA
    cd0b931 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. remove "next stage"

    @jdcormie
    jdcormie committed Jul 26, 2021
    Copy the full SHA
    54cb5df View commit details
    Browse the repository at this point in the history