Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stub: add ServerCallStreamObserver.setOnCloseHandler(...) (#5895) #8452

Merged
merged 11 commits into from Sep 21, 2021
Merged

stub: add ServerCallStreamObserver.setOnCloseHandler(...) (#5895) #8452

merged 11 commits into from Sep 21, 2021

Commits on Aug 26, 2021

  1. stub: add ServerCallStreamObserver.setOnSuccessHandler(...) (grpc#5895) 

    This allows for user code to be notified when the messages are actually
put on the wire and the stream is closed.
    @morgwai
    morgwai committed Aug 26, 2021
    Copy the full SHA
    b68d403 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. stub: rename onSuccessHandler to onFinishHandler 

    The handler is called also after onError(...), so onSuccess sounds
confusing in this situation.
    @morgwai
    morgwai committed Sep 1, 2021
    Copy the full SHA
    ec8c489 View commit details
    Browse the repository at this point in the history

  2. stub: add @experimentalapi to setOnFinishHandler()

    @morgwai
    morgwai committed Sep 1, 2021
    Copy the full SHA
    84b4e23 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. stub: add test for setOnFinishHandler() in unary client case

    @morgwai
    morgwai committed Sep 2, 2021
    Copy the full SHA
    aecf383 View commit details
    Browse the repository at this point in the history

  2. stub: fix formatting in cannotSetOnFinishHandlerAfterServiceInvocation

    @morgwai
    morgwai committed Sep 2, 2021
    Copy the full SHA
    4408a91 View commit details
    Browse the repository at this point in the history

  3. stub: remove unused var from setOnFinishHandler(...) tests

    @morgwai
    morgwai committed Sep 2, 2021
    Copy the full SHA
    2690d5c View commit details
    Browse the repository at this point in the history

  4. stub: fix javadoc of setOnFinishHandler(...) 

    Fix some formatting and references.
    @morgwai
    morgwai committed Sep 2, 2021
    Copy the full SHA
    3429e67 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. stub: rename onFinishHandler to onCloseHandler

    @morgwai
    morgwai committed Sep 3, 2021
    Copy the full SHA
    b733f20 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2021

  1. stub: apply review comments to setOnCloseHandler() javadoc

    @morgwai
    morgwai committed Sep 4, 2021
    Copy the full SHA
    9720b63 View commit details
    Browse the repository at this point in the history

  2. stub: apply review comments to setOnCloseHandler() javadoc, part 2

    @morgwai
    morgwai committed Sep 4, 2021
    Copy the full SHA
    597c8ae View commit details
    Browse the repository at this point in the history

  3. stub: apply review comments to setOnCloseHandler() javadoc, part 3

    @morgwai
    morgwai committed Sep 4, 2021
    Copy the full SHA
    dd2bb58 View commit details
    Browse the repository at this point in the history