Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist (1.42.x backport) #8690

Merged
merged 3 commits into from Nov 11, 2021
Merged

xds: fix xdsClient resource not exist for invalid resource, fix xdsServerWrapper start on resource not exist (1.42.x backport) #8690

merged 3 commits into from Nov 11, 2021

Commits on Nov 11, 2021

  1. xds: remove filter chain uuid name generator (grpc#8663) 

    Generating a uuid in filterChain breaks the de-duplication detection which causes XdsServer to cycle connections, so removing it.
An empty name is now allowed. The name is currently only used for debug purpose.
    @YifeiZhuang
    YifeiZhuang committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    2de0166 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v1.42.x' of https://github.com/grpc/grpc-java into 1.42.x

    @YifeiZhuang
    YifeiZhuang committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    48e8df4 View commit details
    Browse the repository at this point in the history

  3. xds: fix xdsClient resource not exist for invalid resource, fix xdsSe… 

    …rverWrapper start on resource not exist (grpc#8660)

Fix bugs:
1. Invalid resource at xdsClient, the watcher should have been delivered an error instead of resource not found.
2. If the resource is properly determined to not exist, it shouldn't cause start() to fail. From A36 xDS for Servers:
"XdsServer's start must not fail due to transient xDS issues, like missing xDS configuration from the xDS server."
    @YifeiZhuang
    YifeiZhuang committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    a98e0db View commit details
    Browse the repository at this point in the history