Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

census: fix NPE in calling recordFinishedAttempt() #8706

Merged
merged 2 commits into from Nov 29, 2021
Merged

census: fix NPE in calling recordFinishedAttempt() #8706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32fdeef
census: fix NPE in calling recordFinishedAttempt()
dapengzhang0 Nov 15, 2021
4b0c91b
also update roundtripNanos prior to attemptEnded()
dapengzhang0 Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion census/src/main/java/io/grpc/census/CensusStatsModule.java
View file
Open in desktop
Expand Up @@ -342,7 +342,6 @@ public void outboundMessage(int seqNo) {

@Override
public void streamClosed(Status status) {
attemptsState.attemptEnded();
stopwatch.stop();
roundtripNanos = stopwatch.elapsed(TimeUnit.NANOSECONDS);
Deadline deadline = info.getCallOptions().getDeadline();
Expand All @@ -355,6 +354,7 @@ public void streamClosed(Status status) {
statusCode = Code.DEADLINE_EXCEEDED;
}
}
attemptsState.attemptEnded();
if (inboundReceivedOrClosed.compareAndSet(false, true)) {
if (module.recordFinishedRpcs) {
// Stream is closed early. So no need to record metrics for any inbound events after this
Expand Down Expand Up @@ -522,6 +522,8 @@ void recordFinishedCall() {
tracer.statusCode = status.getCode();
tracer.recordFinishedAttempt();
} else if (inboundMetricTracer != null) {
// activeStreams has been decremented to 0 by attemptEnded(),
// so inboundMetricTracer.statusCode is guaranteed to be assigned already.
inboundMetricTracer.recordFinishedAttempt();
}
if (!module.recordRetryMetrics) {
Expand Down