Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Protobuf to 3.19.1 and Guava to 30.1.1 #8748

Merged
merged 1 commit into from Dec 9, 2021

Commits on Dec 8, 2021

  1. Upgrade Protobuf to 3.19.1 and Guava to 30.1.1

    Protobuf uses Guava 30.1.1, so I upgrade it at the same time. It also
    caused an update to rules_jvm_external and reworking the Bazel build.
    Protobuf no longer requires bind() so they were dropped. Although
    Protobuf's protobuf_deps() brings in rules_jvm_external, and so we don't
    need to define it ourselves, it seems better to define it directly and
    not depend on transitive deps since we use it directly.
    
    Protobuf now has support for maven_install() by exposing
    PROTOBUF_MAVEN_ARTIFACTS, which required reorganizing the WORKSPACE to
    use maven_install() after loading protobuf. Protobuf still doesn't
    define target overrides for itself so we still maintain those. When
    reorganizing the WORKSPACE I noticed http_archive should ideally be
    above io_grpc_grpc_java as most users will need it there, so I fixed
    that since there were lots of other load()-reordering already.
    ejona86 committed Dec 8, 2021
    Copy the full SHA
    4d1c04a View commit details
    Browse the repository at this point in the history