Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Use wrr_locality LB and support load_balancing_policy in Cluster #9141

Merged
merged 6 commits into from May 6, 2022
Merged

xds: Use wrr_locality LB and support load_balancing_policy in Cluster #9141

merged 6 commits into from May 6, 2022

Commits on May 3, 2022

  1. Use new wrr_locality LB policy. 

    Instead of providing round robin or least request configurations directly, ClientXdsClient now wraps them in a WRR locality config.

ClusterResolverLoadBalancer passes this configuration directly to PriorityLoadBalancer to use as the endpoint LB policy it provides to ClusterImplLoadBalancer. A new ResolvedAddresses attribute is also set that has all the locality weights. This is needed by WrrLocalityLoadBalancer when it configures WeightedTargetLoadBalancer.
    @temawi
    temawi committed May 3, 2022
    Copy the full SHA
    75d3e43 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. xds: Use load_balancing_policy if provided in Cluster. 

    Renames the LegacyLoadBalancerConfigFactory to just LoadBalancerConfigFactory and gives it responsibility for both the legacy and the new LB config mechanism.

The new configuration mechanism is explained in gRFC A52: grpc/proposal#298
    @temawi
    temawi committed May 4, 2022
    Copy the full SHA
    8a02214 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2022

  1. Better localityWeights handling.

    @temawi
    temawi committed May 6, 2022
    Copy the full SHA
    84bc3da View commit details
    Browse the repository at this point in the history

  2. Review feedback.

    @temawi
    temawi committed May 6, 2022
    Copy the full SHA
    735956d View commit details
    Browse the repository at this point in the history

  3. Fail the whole conversion process on the first conversion failure.

    @temawi
    temawi committed May 6, 2022
    Copy the full SHA
    54b007e View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary casts.

    @temawi
    temawi committed May 6, 2022
    Copy the full SHA
    fbfb33e View commit details
    Browse the repository at this point in the history