Commits on Jul 8, 2022

1. Service config parse failures should be UNAVAILABLE …

   INVALID_ARGUMENT is propagated to the data plane if no previous config
   is available. INVALID_ARGUMENT is reserved for application use; LBs
   should pretty much use UNAVAILABLE exclusively.
   
   While most of the changes are in xds, there do not appear to be likely
   xds code paths that would propagate a bad status to the data plane.
   Internal policies either don't use parseLoadBalancingPolicyConfig() and
   instead have their configuration objects constructed directly or are
   constructed transitively through the cluster manager which uses INTERNAL
   if there's a child failure. There was a worrisome hole before this
   commit for StatusRuntimeExceptions received by the cluster manager, but
   the audit didn't find any locations throwing such an exception.
   User-selected policies produce a NACK and are protected from the
   existing xds client watcher paths. The worst that appears could happen
   is the channel could panic (which uses INTERNAL) if a bug let a bad
   configuration through.

   

   ejona86 committed Jul 8, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 6d39f2f
   • Browse repository at this point

   Copy the full SHA

   6d39f2f View commit details

   Browse the repository at this point in the history