Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp: add max connection idle at OkHttpServer and fix test #9533

Merged
merged 4 commits into from Sep 9, 2022

Conversation

YifeiZhuang
Copy link
Contributor

@YifeiZhuang YifeiZhuang commented Sep 9, 2022

Revert "Revert "okhttp: add max connection idle at OkHttpServer (#9494)" (#9528)"
#9494

The test should wait until stream removed before idle connection manager kicks in. Use pingpong as a barrier for that.

fix #9503

@YifeiZhuang YifeiZhuang merged commit eac4178 into grpc:master Sep 9, 2022
@YifeiZhuang YifeiZhuang deleted the okhttp-un-revert-idle-manager branch September 9, 2022 19:53
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Oct 6, 2022
* Revert "Revert "okhttp: add max connection idle at OkHttpServer (grpc#9494)" (grpc#9528)"

This reverts commit 95b9d6d and fixed flaky test.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

okhttp maxConnectionIdleTimer_respondWithError is flaky
2 participants