core: Assure that context cancellationCause set (1.49.x backport) #9549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core: Assure that context cancellationCause is set Makes sure that whenever a context is in a cancelled state, we also have a cancellationCause.
|
On second thought, for this it may be best to just let it go in a release. I don't know if very many people are looking at the Context cancellationCause, but if they are they'll see a different exception now. Probably best not to put that in a patch release since it isn't a recent regression. |
|
This can go out with the next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9501
Makes sure that whenever a context is in a cancelled state, we also have
a cancellationCause