Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Free unused MessageProducer in RetriableStream (1.45.x backport) #9853

Merged
merged 1 commit into from Jan 20, 2023
Merged

core: Free unused MessageProducer in RetriableStream (1.45.x backport) #9853

merged 1 commit into from Jan 20, 2023

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jan 20, 2023

This prevents leaking message buffers.

Fixes #9563

Backport of #9846

@ejona86
core: Free unused MessageProducer in RetriableStream
d308de8 
This prevents leaking message buffers.

Fixes grpc#9563
@YifeiZhuang
Copy link
Contributor

oh should it be on branch 1.49?

@ejona86
Copy link
Member Author

ejona86 commented Jan 20, 2023

Nope. 1.45. Yeah, it's an older one.

@ejona86
Copy link
Member Author

ejona86 commented Jan 20, 2023

@YifeiZhuang, see b/264866811

@ejona86 ejona86 merged commit 85988ae into grpc:v1.45.x Jan 20, 2023
@ejona86 ejona86 deleted the backport-retry-free-inbound-on-cancel-1.45 branch January 20, 2023 22:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YifeiZhuang YifeiZhuang YifeiZhuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ejona86 @YifeiZhuang