examples:Client and Server sharing example #9969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larry-safran
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
YifeiZhuang
reviewed
Mar 22, 2023
examples/src/main/java/io/grpc/examples/multiplex/MultiplexingServer.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/multiplex/EchoServer.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/multiplex/EchoServer.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/multiplex/EchoServer.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/multiplex/SharingClient.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/multiplex/SharingClient.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Mar 22, 2023
examples/src/main/java/io/grpc/examples/multiplex/EchoServer.java
Outdated
Show resolved
Hide resolved
| try { | ||
| SharingClient client = new SharingClient(channel); | ||
|
|
||
| CountDownLatch finishLatch = client.initiateEchos(echoInput, echoOutput); |
There was a problem hiding this comment.
You might consider using the future stub instead. It makes waiting much more natural.
There was a problem hiding this comment.
Switched to future, but kept streaming stub
larry-safran
force-pushed
the
multiplex_example
branch
from
c5904cf
to
6386cda
Compare
|
@YifeiZhuang Ready for rereview |
YifeiZhuang
reviewed
Mar 24, 2023
examples/src/main/java/io/grpc/examples/multiplex/SharingClient.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/grpc/examples/multiplex/SharingClient.java
Outdated
Show resolved
Hide resolved
YifeiZhuang
reviewed
Mar 27, 2023
YifeiZhuang
approved these changes
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of example Fixit
Fixes b/259285817