Merge pull request #1297 from murgatroid99/grpc-js_dont_test_ipv6_rec…

…ords grpc-js: tests: skip checking for IPv6 addresses from DNS servers
grpc · Mar 10, 2020 · 0956c24 · 0956c24
2 parents c3fc579 + ca18cca
commit 0956c24
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/packages/grpc-js/test/test-resolver.ts b/packages/grpc-js/test/test-resolver.ts
@@ -214,7 +214,9 @@ describe('Name Resolver', () => {
       const resolver = resolverManager.createResolver(target, listener);
       resolver.updateResolution();
     });
-    it('Should resolve a DNS name to an IPv6 address', done => {
+    /* TODO(murgatroid99): re-enable this test, once we can get the IPv6 result
+     * consistently */
+    it.skip('Should resolve a DNS name to an IPv6 address', done => {
       const target = 'loopback6.unittest.grpc.io';
       const listener: resolverManager.ResolverListener = {
         onSuccessfulResolution: (
@@ -255,14 +257,8 @@ describe('Name Resolver', () => {
                 addr.port === 443
             )
           );
-          assert(
-            addressList.some(
-              addr =>
-                isTcpSubchannelAddress(addr) &&
-                addr.host === '::1' &&
-                addr.port === 443
-            )
-          );
+          /* TODO(murgatroid99): check for IPv6 result, once we can get that
+           * consistently */
           done();
         },
         onError: (error: StatusObject) => {