sync the handshaker.proto with the internal version #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc/gcp/handshaker.proto
Outdated
| // the peer. The access token MUST be strongly bound to the ALTS credentials | ||
| // used to establish the connection that the token is sent over. | ||
| optional string access_token = 3; | ||
| // An identity token created by GKE MDS only intended for use in Direct Path |
There was a problem hiding this comment.
Can we leave the original wording as-is and just omit the word "access"?
There was a problem hiding this comment.
Makes sense. Done.
matthewstevenson88
approved these changes
Apr 4, 2024
grpc/gcp/handshaker.proto
Outdated
| // (Optional) An access token created by the caller only intended for use in | ||
| // ALTS connections. The access token that should be used to authenticate to | ||
| // the peer. The access token MUST be strongly bound to the ALTS credentials | ||
| // An token created by the caller only intended for use in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.