Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hashable conformance to GRPC.ConnectionTarget #1876

Merged
merged 1 commit into from
May 2, 2024

Conversation

clintonpi
Copy link
Contributor

Motivation:

GRPC.ConnectionTarget is not Hashable and, for example, cannot be stored in a set.

Modifications:

Add Hashable conformance to GRPC.ConnectionTarget.

Result:

GRPC.ConnectionTarget is now Hashable.

Motivation:

`GRPC.ConnectionTarget` is not `Hashable` and, for example, cannot be stored in a set.

Modifications:

Add `Hashable` conformance to `GRPC.ConnectionTarget`.

Result:

`GRPC.ConnectionTarget` is now `Hashable`.
@gjcairo gjcairo merged commit 07eade2 into grpc:main May 2, 2024
14 checks passed
@clintonpi clintonpi deleted the hashable-connection-target branch May 2, 2024 13:08
@glbrntt glbrntt added the semver-minor ↑ Requires a SemVer Minor version change label May 14, 2024
glbrntt pushed a commit to glbrntt/grpc-swift that referenced this pull request May 14, 2024
Motivation:

`GRPC.ConnectionTarget` is not `Hashable` and, for example, cannot be stored in a set.

Modifications:

Add `Hashable` conformance to `GRPC.ConnectionTarget`.

Result:

`GRPC.ConnectionTarget` is now `Hashable`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor ↑ Requires a SemVer Minor version change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants