-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cloned init_submodules.sh in prereqs (#1349) #1352
base: master
Are you sure you want to change the base?
Conversation
The problem with building the docker-compose example was due to the additional line copying the `init_submodule.sh` script from the context. The line just above was cloning the repository though, so there is no need to COPY that script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kaszanas Thanks for the PR!
I believe this COPY
line you're removing has its purpose — it's for using a local init_submodules.sh
instead of the one from github.
So i'd like to understand the problem better before proceeding with this PR.
So for context, i believe you're seeing the issue mentioned here before this PR.
Do you mind sharing your docker version where you're seeing this error?
I'm on Docker version 20.10.8 (on Mac) and i'm not seeing the same error.
Thanks!
Sure thing, Yes there's one closed issue, and another one which explores further another error down the line. I'm running Docker on Windows. As I have been performing a clean install recently I have the most recent Docker version (for a more precise answer I'd have to verify). There may be a couple of things to check:
|
Yes.. have understood about that :)
Thanks for clarifying on the platform! I'm running Docker That is, i can successfully build using this command:
I guess that's the same command you're running and it's failing? I'm wondering what is the difference here.
I'm not sure what exactly to check here. Could you clarify? Do you have a theory on what might be missing? |
I'm running the docker compose command which is supposed to build and run all images I guess. This is following the instructions from the TypeScript example. I will see if the docker build command by itself runs as intended. My immediate thought (a guess) is that there's something off in passing the context to docker. |
I was running docker compose as well.. But it was succeeding for me.. The command i used is:
|
The problem with building the docker-compose example was due to the additional line copying the
init_submodule.sh
script from the context. The line just above was cloning the repository though, so there is no need to COPY that script.This is supposed to be solving the issue: #1349
While solving this, another issue was discovered: